Metrics cleanups in other packages #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
konradreiche and
mterwill
and removed request for
a team
fishy
commented
Nov 1, 2022
| @@ -422,6 +421,8 @@ func recordStatusCode(counters counterGenerator) Middleware { | |||
| // RecordStatusCode should generally not be used directly, instead use the | |||
| // NewBaseplateServer function which will automatically include RecordStatusCode | |||
| // as one of the Middlewares to wrap your handlers in. | |||
| // | |||
| // Deprecated: This is deprecated with statsd metrics. | |||
There was a problem hiding this comment.
We should have waited for this cleanup before doing #573 😅
konradreiche
approved these changes
Nov 1, 2022
kylelemons
approved these changes
Nov 2, 2022
Remove/deprecate statsd metrics, and rename an httpbp prometheus metrics similar to the thriftbp one in reddit#581.
fishy
force-pushed
the
other-metrics-cleanup
branch
from
9161f12
to
7d9ec0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove/deprecate statsd metrics, and rename an httpbp prometheus metrics similar to the thriftbp one in
#581.