maxprocs: Print newline after log #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mterwill
requested review from
pacejackson and
ghirsch-reddit
and removed request for
a team
mterwill
commented
Nov 4, 2022
| @@ -74,7 +74,7 @@ var ( | |||
| ubermaxprocs.Set( | |||
| ubermaxprocs.Min(2), | |||
| ubermaxprocs.Logger(func(s string, i ...interface{}) { | |||
| fmt.Fprintf(os.Stderr, s, i...) // contains context | |||
| fmt.Fprintf(os.Stderr, s+"\n", i...) // contains context | |||
There was a problem hiding this comment.
Another concern of not using a real logging library is that this could get interleaved, but (a) this happens early in setup, so there shouldn't be any other goroutines running and (b) these log messages are small, should always be smaller than PIPE_BUF, so the OS guarantees they'll be atomic. (er - I guess that's for different processes, not sure what Go does but seems fine https://go.dev/play/p/WIyt9Npaii9)
fishy
approved these changes
Nov 4, 2022
pacejackson
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Since we're not using a real logger here (artifact of previous implementation, I think because logging isn't initialized when this is called – but if that's not the case we can update to use zap) we weren't logging a newline. This was not caught by tests because the maxprocs library doesn't bake in any testing affordances so we had to stub it out.
📜 Details
Before:
After:
🧪 Testing Steps / Validation
Will test in a sample service.
✅ Checks