tracing: Do not auto register ErrorReporterCreateServerSpanHook #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
konradreiche,
pacejackson and
ghirsch-reddit
and removed request for
a team
konradreiche
approved these changes
Feb 6, 2023
pacejackson
approved these changes
Feb 6, 2023
ghirsch-reddit
approved these changes
Feb 7, 2023
Currently tracing.InitFromConfig, which is called from baseplate.New, auto registers ErrorReporterCreateServerSpanHook. With the prometheus metrics we already have very good visibility on the errors happened on thrift/grpc/http servers, and those additional sentry reports mostly just adds noise and cost without being useful. Also in the current setup there's not really an easy way for service owners to unregister ErrorReporterCreateServerSpanHook after they called baseplate.New. As a result, flip it to opt-in. If a service really want it, they can register it themselves in their main function, after baseplate.New call.
fishy
force-pushed
the
tracing-no-error-report-sentry
branch
from
878e42b
to
f95e2b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tracing.InitFromConfig, which is called from baseplate.New, auto registers ErrorReporterCreateServerSpanHook. With the prometheus metrics we already have very good visibility on the errors happened on thrift/grpc/http servers, and those additional sentry reports mostly just adds noise and cost without being useful. Also in the current setup there's not really an easy way for service owners to unregister ErrorReporterCreateServerSpanHook after they called baseplate.New.
As a result, flip it to opt-in. If a service really want it, they can register it themselves in their main function, after baseplate.New call.