feat: Improve shutdown Delay default #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a baseplate server is shutting down in k8s * baseplate calls func (srv *Server) Shutdown(ctx context.Context) error which does the following: * Shutdown works by first closing all open listeners * k8s is attempting to remove the endpoint for the endpoints group and thus make (new) incoming traffic to the pod 0 This is a race condition because some callers are still trying to connect. We have empirically seen that the 5 second default is good enough for most services. Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
requested review from
fishy,
pacejackson and
ghirsch-reddit
and removed request for
a team
fishy
approved these changes
May 4, 2023
pacejackson
approved these changes
May 4, 2023
davinci26
added a commit
to davinci26/baseplate.py
that referenced
this pull request
May 5, 2023
When a baseplate server is shutting down in k8s * baseplate calls func (srv *Server) Shutdown(ctx context.Context) error which does the following: * Shutdown works by first closing all open listeners * k8s is attempting to remove the endpoint for the endpoints group and thus make (new) incoming traffic to the pod 0 This is a race condition because some callers are still trying to connect. We have empirically seen that the 5 second default is good enough for most services. See also reddit/baseplate.go#615 Signed-off-by: Sotiris Nanopoulos <[email protected]>
chriskuehl
pushed a commit
to reddit/baseplate.py
that referenced
this pull request
Apr 30, 2024
* feat: Improve shutdown Delay default When a baseplate server is shutting down in k8s * baseplate calls func (srv *Server) Shutdown(ctx context.Context) error which does the following: * Shutdown works by first closing all open listeners * k8s is attempting to remove the endpoint for the endpoints group and thus make (new) incoming traffic to the pod 0 This is a race condition because some callers are still trying to connect. We have empirically seen that the 5 second default is good enough for most services. See also reddit/baseplate.go#615 Signed-off-by: Sotiris Nanopoulos <[email protected]> * improve comment Signed-off-by: Sotiris Nanopoulos <[email protected]> --------- Signed-off-by: Sotiris Nanopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a baseplate server is shutting down in k8s
baseplate calls func (srv *Server) Shutdown(ctx context.Context) error which does the following:
Shutdown works by first closing all open listeners
k8s is attempting to remove the endpoint for the endpoints group and thus make (new) incoming traffic to the pod 0
This is a race condition because some callers are still trying to connect. We have empirically seen that the 5 second default is good enough for most services.