log: Also stamp version from env var #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this as the last fallback. This helps reproducible docker image builds from monorepos, as env var can be stamped from k8s yaml and totally outside of the docker image (so we can keep the docker image intact when no other changes is in the service's dependency tree).
fishy
requested review from
konradreiche and
pacejackson
and removed request for
a team
pacejackson
approved these changes
Jun 29, 2023
kylelemons
approved these changes
Jun 29, 2023
kylelemons
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this as the last fallback.
This helps reproducible docker image builds from monorepos, as env var can be stamped from k8s yaml and totally outside of the docker image (so we can keep the docker image intact when no other changes is in the service's dependency tree).