Update go support to 1.20+1.21 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacejackson
approved these changes
Sep 8, 2023
Comment on lines
+776
to
+777
| errorsbp.Prefix("read fully", err), | ||
| errorsbp.Prefix("close", r.Close()), |
There was a problem hiding this comment.
ooc, why do we still need to use errorsbp here?
| if !errors.Is(batchErr, err) { | ||
| t.Errorf("%v is not wrapped by %v", err, batchErr) | ||
| } | ||
| if got, want := errorsbp.BatchSize(err), len(errList); got != want { |
There was a problem hiding this comment.
is there something we can/should replace errorsbp.BatchSize with?
There was a problem hiding this comment.
see 1edc07c
basically it's much easier to use than handle a few different cases yourself (check nil, check not a batch error, then try to unwrap to a batch and get the size).
Also upgrade thrift to 0.19.0. Also deprecate errorsbp.Batch.
kylelemons
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade thrift to 0.19.0.
Also deprecate errorsbp.Batch.