tracing: skip reconfiguration if tracer already configured #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redloaf
requested review from
fishy,
kylelemons and
pacejackson
and removed request for
a team
kylelemons
approved these changes
Nov 8, 2023
kylelemons
reviewed
Nov 8, 2023
fishy
requested changes
Nov 8, 2023
internalv2compat/compat.go
Outdated
Comment on lines
69
to
70
| v2TracingEnabledMutex sync.RWMutex | ||
| v2TracingEnabled bool |
There was a problem hiding this comment.
I considered it but picked a mutex because this should only be referenced during setup/init, and I feel like the benefit of a memory barrier outweighs the performance benefits of atomics.
fishy
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
In baseplate.go v2 we configure a global opentracing tracer. Currently, calling
baseplate.Newwill override the new tracer. This change prevents the override using a flag ininternalv2compat.📜 Details
If
internalv2compat.SetV2TracingEnabled(true)is called beforeInitGlobalTracer, the opentracing global tracer will not be configured, and a message will be logged.🧪 Testing Steps / Validation
✅ Checks