Update supported go versions to 1.21+1.22 #643
Conversation
Split from #641 to fix 1.22 specific problems.
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
| @@ -50,12 +49,14 @@ func TestMetrics(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| got := []string{} | |||
| got := make(map[string]bool) | |||
There was a problem hiding this comment.
changed this to a subset check because https://github.com/reddit/baseplate.go/actions/runs/7807507022/job/21333706033?pr=641
There was a problem hiding this comment.
why did this become an issue in 1.22?
There was a problem hiding this comment.
1.22 exposes more metrics and we were testing that they match exactly.
There was a problem hiding this comment.
you could steal what we do in baseplate/v2:
(and add a few 1.22 metrics, which we haven't yet)
There was a problem hiding this comment.
yea but I don't think it's worth it to keep updating this list with every go release.
this is basically just testing
baseplate.go/internal/admin/server.go
Lines 28 to 30 in 49c0448
| @@ -50,12 +49,14 @@ func TestMetrics(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| got := []string{} | |||
| got := make(map[string]bool) | |||
There was a problem hiding this comment.
why did this become an issue in 1.22?
| @@ -50,12 +49,14 @@ func TestMetrics(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| got := []string{} | |||
| got := make(map[string]bool) | |||
There was a problem hiding this comment.
you could steal what we do in baseplate/v2:
(and add a few 1.22 metrics, which we haven't yet)
Split from #641 to fix 1.22 specific problems.