Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thriftbp: Report request/response payload sizes from client side #650

Merged
merged 1 commit into from
May 7, 2024

Commits on May 6, 2024

  1. thriftbp: Report request/response payload sizes from client side

    We currently already have a middleware to report that from the server
    side, but that's simulated by reconstruct THeaderProtocols and
    read/write to them, which will not include the header size and will not
    reflect compressions (zlib, etc.).
    
    This client side reporting is done directly at the TTransport (TSocket)
    level, so it will reflect the exact number actually read/written at that
    level. If zlib is enabled in THeaderProtocol the size will reflect
    compressed payload. The only thing it will not reflect is potential SSL
    layer (e.g. when using TSSLSocket over TSocket, which we don't support
    yet).
    fishy committed May 6, 2024
    Configuration menu
    Copy the full SHA
    93cb581 View commit details
    Browse the repository at this point in the history