Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate #653

Merged
merged 1 commit into from
May 9, 2024
Merged

thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions thriftbp/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ type ServerConfig struct {
//
// Report the payload size metrics with this sample rate.
// If not set none of the requests will be sampled.
//
// Deprecated: Server side payload size reporting is always 100% enabled when
// using NewBaseplateServer.
ReportPayloadSizeMetricsSampleRate float64

// Optional, used by NewBaseplateServer and NewServer.
Expand Down Expand Up @@ -139,9 +142,8 @@ func NewBaseplateServer(
) (baseplate.Server, error) {
middlewares := BaseplateDefaultProcessorMiddlewares(
DefaultProcessorMiddlewaresArgs{
EdgeContextImpl: bp.EdgeContextImpl(),
ErrorSpanSuppressor: cfg.ErrorSpanSuppressor,
ReportPayloadSizeMetricsSampleRate: cfg.ReportPayloadSizeMetricsSampleRate,
EdgeContextImpl: bp.EdgeContextImpl(),
ErrorSpanSuppressor: cfg.ErrorSpanSuppressor,
},
)
middlewares = append(middlewares, cfg.Middlewares...)
Expand Down
Loading