kafkabp: Add AWSAvailabilityZoneIDRackID rack implementation #662
Conversation
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
| id, err := awsZoneIDRackID() | ||
| if err != nil { | ||
| awsRackFailure.Inc() | ||
| slog.Warn("Failed to get AWS availability zone id as rack id", "err", err) |
There was a problem hiding this comment.
🔕 LogDNA will not show the error message to users when the error is moved into the structured portion of the log. I typically recommend having the error as part of the human portion instead, since error is not really adding things to filter against or aggregate beyond what you can already do with the message.
There was a problem hiding this comment.
my experience is the opposite, that with errors in kv pair makes it easier to find exact errors (it's probably not that helpful if you want to search for partial error messages) on logdna, for use cases like "how many time did this error happen, did we have a spike during this time window?".
with a better logging ui (like GCP's log explorer) you can add an kv value to the summary line in the ui if needed, which is the best of both worlds, but we just don't have that unfortunately.
No description provided.