Skip to content

Commit

Permalink
Initialize tracing export code to run earlier in the startup process. (
Browse files Browse the repository at this point in the history
…#983)

This avoids a race-condition with our gevent patching.

Co-authored-by: Trevor Riles <[email protected]>
  • Loading branch information
trevorriles and Trevor Riles authored Sep 16, 2024
1 parent e452393 commit c1acbd0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion baseplate/server/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ def load_app_and_run_server() -> None:
logger.info("Metrics are not configured, Prometheus metrics will not be exported.")

configure_logging(config, args.debug)
configure_tracing()

app = make_app(config.app)
listener = make_listener(args.bind)
Expand Down
3 changes: 2 additions & 1 deletion bin/baseplate-serve
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ except ImportError:
pass


from baseplate.server import load_app_and_run_server
from baseplate.server import configure_tracing, load_app_and_run_server

configure_tracing()
load_app_and_run_server()

0 comments on commit c1acbd0

Please sign in to comment.