Temporarily restore Python 3.8 support #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskuehl
added a commit
that referenced
this pull request
Nov 13, 2024
This reverts commit f1f2f08.
chriskuehl
added a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily reverts #1003 as we want to keep the 2.7.1 release small. We will un-revert it in a day or two once we make the 2.7.1 release.
This ended up being a bit tricker than I hoped since Ruff had rewritten a lot of type annotations to make them no longer compatible with 3.8, so I reverted that first as my original attempt to unwind it (#1022) ended up being very complex.