Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom 404 view that doesn't echo path #800

Merged
merged 1 commit into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. Provide custom 404 view that doesn't echo path

    We get some bogus bug bounty submissions that talk about HTML injection
    on our 404 Not Found pages, which are default Pyramid views which echo
    out the `path` of the Request that isn't found. So you can put some
    gibberish in there, but it looks real jank and would not be a valid
    social engineering attack, but it should be simple for us to just
    default this to be quieter so we don't receive these reports.
    
    Ref: https://docs.pylonsproject.org/projects/pyramid/en/latest/narr/hooks.html
    Example: https://ads-api.reddit.com/this_is_a_test_where_i_could_spoof_whatever_i_guess
    
    - [x] CI tests (if present) are passing
    - [x] Adheres to code style for repo
    - [x] Contributor License Agreement (CLA) completed if not a Reddit employee
    ketralnis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    216ce42 View commit details
    Browse the repository at this point in the history