Update Thift Pool metrics to use class qualname #805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Copied and updated from @ckwang8128:
The
__name__
directive will useIface
as the pool label for every single thrift pool defined for a service, since the Thrift compiler usesClient
as the class.We likely want
__qualname__
instead to get a more identifiable label for these pool metrics.📜 Details
Going forward the label will change from
IFace
to the full object reference.Example:
Iface
->TestThriftContextFactory.context_factory.<locals>.Iface
🧪 Testing Steps / Validation
I've locally run
docker-compose run baseplate make test
and updated the thrift tests to reflect the change.✅ Checks
- [ ] Contributor License Agreement (CLA) completed if not a Reddit employee