Move pyramid otel instrumentation to BaseplateConfigurator #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the instrumentation logic to the initialization of the BaseplateConfigurator class instead of being an import side-effect.
|
@chriskuehl I believe this is closer to what you were looking for in the main PR. When testing this against some ads services I ran into the case where they didn't import the module directly and missed instrumentation because of it. Any service integrating pyramid with baseplate should use the BaseplateConfigurator class so I think this is a good landing spot. |
chriskuehl
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the instrumentation logic to the initialization of the BaseplateConfigurator class instead of being an import side-effect.