fix(compiler): cannot always default to prop name (#440)

redgeoff · Aug 8, 2021 · 2f88fad · 2f88fad
1 parent f3eabc2
commit 2f88fad
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/src/compiler/compiler.factory.test.js b/src/compiler/compiler.factory.test.js
@@ -64,7 +64,7 @@ it('should compile when factory is in the root of the definition', () => {
 
   factoryShouldCreateUniqueForms(formFactory);
 
-  expect(formFactory.getClassName()).toEqual('app.FormFactory');
+  expect(formFactory.getClassName()).toEqual('Factory');
 });
 
 it('should handle template parameters in a nested factory', () => {

diff --git a/src/compiler/compiler.js b/src/compiler/compiler.js
@@ -187,9 +187,6 @@ export class Compiler {
   // The parentProps define values for the template parameters in props and allow us to make pieces
   // of our components dynamic.
   compile(props, parentProps, className) {
-    if (className === undefined && props.name !== undefined) {
-      className = props.name;
-    }
     return this._getWrappedComponentClass(
       props.component,
       props,

diff --git a/src/component/mson-component.test.js b/src/component/mson-component.test.js
@@ -19,12 +19,12 @@ it('should build in constructor', () => {
 it('should not preserve class name', () => {
   const component = new MSONComponent({
     definition: {
-      name: 'MyField',
+      name: 'name',
       component: 'TextField',
     },
   });
 
-  expect(component.getClassName()).toEqual('MyField');
+  expect(component.getClassName()).toEqual('TextField');
 });
 
 it('should set and get compiler', () => {