Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command 'make build' not downloading dependencies. #149

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Katka92
Copy link
Contributor

@Katka92 Katka92 commented Jul 13, 2022

When running the command make build or make test, no dependencies are downloaded. Fixing the issue by replacing 'go get' to 'go install'.

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

Hi @Katka92. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhopp
Copy link

rhopp commented Jul 13, 2022

Just a note: this is since go 1.18 (kubebuilder reflected this in its templates here kubernetes-sigs/kubebuilder#2486)

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, Katka92

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier
Copy link
Member

/ok-to-test

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #149 (f070679) into main (9146b37) will increase coverage by 0.28%.
The diff coverage is 90.10%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   88.20%   88.48%   +0.28%     
==========================================
  Files          29       31       +2     
  Lines        2712     2943     +231     
==========================================
+ Hits         2392     2604     +212     
- Misses        234      249      +15     
- Partials       86       90       +4     
Impacted Files Coverage Δ
controllers/component_controller.go 76.24% <75.00%> (-0.20%) ⬇️
...pplicationsnapshotenvironmentbinding_controller.go 83.46% <83.46%> (ø)
...napshotenvironmentbinding_controller_conditions.go 86.36% <86.36%> (ø)
gitops/generate.go 97.87% <95.23%> (-0.77%) ⬇️
controllers/component_controller_finalizer.go 71.73% <100.00%> (-5.08%) ⬇️
gitops/generate_build.go 97.74% <100.00%> (+0.06%) ⬆️
gitops/gitops.go 98.14% <100.00%> (+0.74%) ⬆️
gitops/resources/kustomization.go 100.00% <100.00%> (ø)
pkg/util/util.go 97.34% <100.00%> (+0.75%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b49f7...f070679. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants