-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command 'make build' not downloading dependencies. #149
Conversation
Hi @Katka92. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Just a note: this is since go 1.18 (kubebuilder reflected this in its templates here kubernetes-sigs/kubebuilder#2486) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnmcollier, Katka92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 88.20% 88.48% +0.28%
==========================================
Files 29 31 +2
Lines 2712 2943 +231
==========================================
+ Hits 2392 2604 +212
- Misses 234 249 +15
- Partials 86 90 +4
Continue to review full report at Codecov.
|
When running the command
make build
ormake test
, no dependencies are downloaded. Fixing the issue by replacing 'go get' to 'go install'.