Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DEVHAS-661): Remove Environment API #480

Merged

Conversation

michael-valdron
Copy link
Contributor

@michael-valdron michael-valdron commented May 27, 2024

What does this PR do?:

Removes usage of the Environment API that was removed in konflux-ci/application-api#81.

Which issue(s)/story(ies) does this PR fixes:

fixes DEVHAS-661

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented May 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@michael-valdron
Copy link
Contributor Author

/retest

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@michael-valdron
Copy link
Contributor Author

/retest

1 similar comment
@michael-valdron
Copy link
Contributor Author

/retest

Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Contributor Author

Documentation
Client Impact

N/A

@michael-valdron
Copy link
Contributor Author

/retest

1 similar comment
@thepetk
Copy link
Contributor

thepetk commented May 29, 2024

/retest

@michael-valdron michael-valdron merged commit 926cef4 into redhat-appstudio:main May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants