Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync midstream changes #3

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Sync midstream changes #3

merged 1 commit into from
Jan 19, 2024

Conversation

chmeliik
Copy link
Member

@chmeliik chmeliik commented Jan 17, 2024

From #6

@chmeliik chmeliik marked this pull request as draft January 17, 2024 12:28
@chmeliik chmeliik force-pushed the test-EC-checks branch 4 times, most recently from c95a25e to 19ae506 Compare January 18, 2024 09:02
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@chmeliik chmeliik changed the title temp: test EC checks with new policy Add labels required by the Red Hat EC policy Jan 18, 2024
@chmeliik
Copy link
Member Author

/retest

@chmeliik
Copy link
Member Author

PTAL

The 1 failing EC check is a dependency with a CVE, which I'm not planning to address. The CVE is not present in Syft 0.100.0 anymore, but we can't build that one hermetically yet (need containerbuildsystem/cachi2#427).

In other words, I'll be ignoring that one and merging things anyway to make some progress with the release machinery

@chmeliik
Copy link
Member Author

You can also review the related #6 instead - I'll take your approval on either of these as approval for both 🙂

As for why we need two PRs, see the README (maybe with the updates from #5)

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik chmeliik changed the title Add labels required by the Red Hat EC policy Sync midstream changes Jan 19, 2024
@chmeliik chmeliik merged commit fe1934b into redhat-latest Jan 19, 2024
1 of 2 checks passed
@chmeliik chmeliik deleted the test-EC-checks branch January 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants