Adjust 'access-control-namespace' test to be Optional #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
remove_invalid_ns
branch
from
91e91a5
to
be87603
Compare
sebrandon1
changed the title
edcdavid
approved these changes
Jul 11, 2024
sebrandon1
force-pushed
the
remove_invalid_ns
branch
from
be87603
to
3b6c917
Compare
|
from change #2242: |
sebrandon1
merged commit bd69f63
into
redhat-best-practices-for-k8s:main
23 checks passed
|
from change #2242: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
access-control-namespacetest to beOptionalinstead ofMandatory.Related links:
For future reference, we decided to change this to optional instead of just removing the
openshift-prefix from the list because we wanted future visibility into potential failures/problems if a partner somehow uses one of these namespaces.