-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor : Renaming certsuite command tool #2379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application is now officially called "Red Hat Best Practices Test Suite for Kubernetes", and it's no longer meant to test CNFs, but any type of workload. However, as it's a too long name/text to be used everytime, to me it's ok to use "Certification Suite" or "CertSuite" instead. I believe there's no need for any CNF/TNF/Workload prefixes in most (if not all) occurrences.
cmd/certsuite/claim/compare/configurations/configurations_test.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/run/run.go
Outdated
@@ -39,8 +39,8 @@ func NewCommand() *cobra.Command { | |||
runCmd.PersistentFlags().Bool("include-web-files", false, "Save web files in the configured output folder") | |||
runCmd.PersistentFlags().Bool("enable-data-collection", false, "Allow sending test results to an external data collector") | |||
runCmd.PersistentFlags().Bool("create-xml-junit-file", false, "Create a JUnit file with the test results") | |||
runCmd.PersistentFlags().String("tnf-image-repository", "quay.io/redhat-best-practices-for-k8s", "The repository where TNF images are stored") | |||
runCmd.PersistentFlags().String("tnf-debug-image", "certsuite-probe:v0.0.7", "Name of the certsuite-probe image") | |||
runCmd.PersistentFlags().String("certsuite-image-repository", "quay.io/redhat-best-practices-for-k8s", "The repository where Certsuite images are stored") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is non-backward compatible change. @sebrandon1 , probably DCI, and QE will need to update to use these new flag names. Also the next certsuite release notes should reflect this changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tell us what are the variables we need to change, to adapt our code to this new change. Thanks!
a02842e
to
89f6aa7
Compare
138f239
to
947e3fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments
from change #2379: |
@bnshr , DCI playbooks need to be adapted to the new variables, please tell us when this change is ready for testing, then we'll integrate the update, thanks! |
We are no longer using two variables - "tnf-image-repository" and "tnf-debug-image" and instead of these using a new variable "certsuite-probe-image" which refers to the image of the probe/debug pod. This PR is ready to be merged. |
from change #2379: |
I'm wondering why this has been merged without having the fix for DCI before... |
@ramperher Sorry about that. Can the fix for the flags be added after or should I revert? |
I've added the fix here: redhatci/ansible-collection-redhatci-ocp#421, we can keep this PR without problems |
Includes:
Dependent Issues / PRs.