-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upload results-spreadsheet certsuite sub-command #2389
Add upload results-spreadsheet certsuite sub-command #2389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, is this a new, standard way of reporting the certsuite results for certification? If so, we'd be interested in knowing how it's working, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, but I haven't finished the review yet.
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
/dci-rerun |
from change #2389: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Mostly suggestions comments and function documentation requests.
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments
… an option for a configured dir for creds
/dci-rerun |
from change #2389: |
822271d
into
redhat-best-practices-for-k8s:main
from change #2389: |
build-depends: redhatci/ansible-collection-redhatci-ocp#421
upload results-spreadsheet
certsuite sub command creates aRedHat Best Practices for K8 Results Spreadsheet
, that is meant to help us keep track on workloads suite test results and document their conclusion.The created spreadsheet contains:
The application is using the google sheet and drive APIs as well as a google cloud project - a project with permissions for the entire cert-and-platform-dev team was created.
In order to use the app, you'll have to download the credentials from the google project and move them to the executable folder in your certsuite cloned repo.
** Note: users who don't have permissions to the google cloud project, can use their own project and credentials (see google sheet quick start)
Usage:
./certsuite upload results-spreadsheet -f <raw-results-file.csv> -d <dest-url> -v <ocp-version(optional)>
Next Steps: Creating a private project to create an
RedHat Best Practices for K8 Results Spreadsheet
for specifically for operators - which will contain more specific aspects.