Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cnf #2452

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove cnf #2452

merged 1 commit into from
Sep 19, 2024

Conversation

bnshr
Copy link
Contributor

@bnshr bnshr commented Sep 18, 2024

This PR removes more cnf references and mostly the doc links 404 error.

build-depends: https://github.com/dci-labs/dallas-pipelines/pull/1227

@dcibot
Copy link
Collaborator

dcibot commented Sep 18, 2024

Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the LEGACY image.

pkg/certsuite/certsuite.go Show resolved Hide resolved
.github/workflows/pre-main.yaml Outdated Show resolved Hide resolved
.github/workflows/tnf-image.yaml Outdated Show resolved Hide resolved
.github/workflows/tnf-image.yaml Outdated Show resolved Hide resolved
@dcibot
Copy link
Collaborator

dcibot commented Sep 18, 2024

@dcibot
Copy link
Collaborator

dcibot commented Sep 18, 2024

@ramperher
Copy link
Collaborator

/dci-rerun

@dcibot
Copy link
Collaborator

dcibot commented Sep 18, 2024

Copy link
Collaborator

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebrandon1
Copy link
Member

@ramperher Let me know when we're good to merge on this side.

@ramperher
Copy link
Collaborator

@ramperher Let me know when we're good to merge on this side.

It's fine to merge it!

@sebrandon1 sebrandon1 merged commit a2e881a into main Sep 19, 2024
34 checks passed
@sebrandon1 sebrandon1 deleted the renaming-docs branch September 19, 2024 13:59
@dcibot
Copy link
Collaborator

dcibot commented Sep 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants