Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to CI golangci-lint #90

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

jzding
Copy link
Member

@jzding jzding commented Jan 27, 2022

CI Linting job fails intermittently due to timeout.
Increase the timeout to 3m. The timeout issue and suggested
solution can be found at
golangci/golangci-lint-action#297

Also update the golangci-lint version to 1.42 since
golangci-lint starts to build docker image with go1.17 with
version 1.42.1.

Signed-off-by: Jack Ding [email protected]

CI Linting job fails intermittently due to timeout.
Increase the timeout to 3m. The timeout issue and suggested
solution can be found at
golangci/golangci-lint-action#297

Also update the golangci-lint version to 1.42 since
golangci-lint starts to build docker image with go1.17 with
version 1.42.1.

Signed-off-by: Jack Ding <[email protected]>
@jzding
Copy link
Member Author

jzding commented Jan 27, 2022

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e475e24 into redhat-cne:main Feb 2, 2022
@jzding jzding deleted the lint branch February 4, 2022 01:27
@aneeshkp
Copy link
Member

/cherry-pick release-4.10

@openshift-cherrypick-robot

@aneeshkp: new pull request created: #99

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants