-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EDA deployment on OCP #239
Conversation
Hi @derekwaters Thank you for your contribution. I'm starting to look over this PR and test it. While I in the process of reviewing can you please add a changelog fragment and update the role's readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @derekwaters I've had some time to do some testing and found a couple of things in addition to the documentation updates that I'd like to see addressed.
Again, thank you for your work on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekwaters Thanks for making the requested changes. This looks really good and I haven't hit any issues in my testing. I did notice a couple of linting errors that need to be addressed, so if you wouldn't mind making the requested changes to fix the linting then I'll get this PR merged.
Apologies @branic I wasn't doing those changes on my normal dev machine and missed my ansible-lint check. Should all be good now. Thanks! |
What does this PR do?
Add EDA component deployment to the aap_install_ocp role to allow automated deployment of EDA alongside AAP and Hub components.
How should this be tested?
Adding the aap_ocp_install_eda var definition to an existing use of aap_install_ocp will also deploy the EDA component. An example playbook which installs AAP controller and EDA onto an existing OCP environment is included below:
Is there a relevant Issue open for this?
No issue open for this
Other Relevant info, PRs, etc
No related info or PRs