Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDA deployment on OCP #239

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

derekwaters
Copy link
Contributor

What does this PR do?

Add EDA component deployment to the aap_install_ocp role to allow automated deployment of EDA alongside AAP and Hub components.

How should this be tested?

Adding the aap_ocp_install_eda var definition to an existing use of aap_install_ocp will also deploy the EDA component. An example playbook which installs AAP controller and EDA onto an existing OCP environment is included below:

---
- name: Install AAP and EDA on an existing OCP Cluster
  vars:
    aap_ocp_install_connection:
      host: "{{ ocp_host }}"
      username: "{{ ocp_username }}"
      password: "{{ ocp_password }}"
      verify_ssl: false
      validate_certs: false
    aap_ocp_install_namespace: aap
    aap_ocp_install_operator:
      channel: "stable-2.4"
    aap_ocp_install_controller:
      instance_name: demo-aap
      replicas: 1
      link_text: "Ansible Automation Platform"
    aap_ocp_install_eda:
      instance_name: demo-eda
      replicas: 1
      link_text: "Ansible Automation Platform EDA"

  block:
    - name: Install AAP and EDA
      ansible.builtin.include_role:
        name: "infra.aap_utilities.aap_ocp_install"

Is there a relevant Issue open for this?

No issue open for this

Other Relevant info, PRs, etc

No related info or PRs

@djdanielsson djdanielsson requested a review from branic June 14, 2024 14:46
@branic
Copy link
Collaborator

branic commented Jun 17, 2024

Hi @derekwaters Thank you for your contribution. I'm starting to look over this PR and test it.

While I in the process of reviewing can you please add a changelog fragment and update the role's readme.

Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @derekwaters I've had some time to do some testing and found a couple of things in addition to the documentation updates that I'd like to see addressed.

Again, thank you for your work on this PR.

Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwaters Thanks for making the requested changes. This looks really good and I haven't hit any issues in my testing. I did notice a couple of linting errors that need to be addressed, so if you wouldn't mind making the requested changes to fix the linting then I'll get this PR merged.

roles/aap_ocp_install/defaults/main.yml Outdated Show resolved Hide resolved
roles/aap_ocp_install/tasks/install-eda.yml Outdated Show resolved Hide resolved
@derekwaters
Copy link
Contributor Author

Apologies @branic I wasn't doing those changes on my normal dev machine and missed my ansible-lint check. Should all be good now. Thanks!

@branic branic merged commit 713d91f into redhat-cop:devel Jun 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants