Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Hotfix helm variable naming conventions #29

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Hotfix helm variable naming conventions #29

merged 2 commits into from
Nov 14, 2023

Conversation

tobiasrdm
Copy link
Contributor

@tobiasrdm tobiasrdm commented Oct 23, 2023

This pull request hotfix the converter to adapt to Helm variables naming conventions:
Variable names should begin with a lowercase letter, and words should be separated with camelcase.

It will convert JOB_NAME to value jobName instead of job_name.

Before:

template2helm convert --template ./examples/slack-notify-job-template.yml --chart ~/tmp/charts
Creating a template for object CronJob
Convert parameter JOB_NAME to value .job_name
Convert parameter SLACK_HOOKS_URL to value .slack_hooks_url
Convert parameter MESSAGE to value .message
Convert parameter SCHEDULE to value .schedule
Convert parameter SUCCESS_JOBS_HISTORY_LIMIT to value .success_jobs_history_limit
Convert parameter FAILED_JOBS_HISTORY_LIMIT to value .failed_jobs_history_limit

After:

template2helm convert --template ./examples/slack-notify-job-template.yml --chart ~/tmp/charts
Creating a template for object CronJob
Convert parameter JOB_NAME to value .jobName
Convert parameter SLACK_HOOKS_URL to value .slackHooksUrl
Convert parameter MESSAGE to value .message
Convert parameter SCHEDULE to value .schedule
Convert parameter SUCCESS_JOBS_HISTORY_LIMIT to value .successJobsHistoryLimit
Convert parameter FAILED_JOBS_HISTORY_LIMIT to value .failedJobsHistoryLimit

@garethahealy garethahealy merged commit c2229f5 into redhat-cop:master Nov 14, 2023
1 check passed
@tobiasrdm tobiasrdm deleted the hotfix/helm-variable-naming-conventions branch November 21, 2023 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants