feat: support for 'workspace/configuration' #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
+ Coverage 23.41% 23.72% +0.30%
==========================================
Files 265 265
Lines 9207 9093 -114
Branches 1677 1243 -434
==========================================
+ Hits 2156 2157 +1
+ Misses 6644 6529 -115
Partials 407 407 ☔ View full report in Codecov by Sentry. |
fbricon
reviewed
Jun 12, 2024
|
no exception anymore with the lua LS, but we're now responding with: I'm not sure how bad it is, but it's weird. Doesn't seem to break anything with the lua LS so far though. |
|
It is not weird it follows lsp spec. If you receive N params you need to return N results. |
Closed
angelozerr
force-pushed
the
workspace_configuration
branch
2 times, most recently
from
690c282
to
e3e296f
Compare
fbricon
reviewed
Jun 12, 2024
src/main/java/com/redhat/devtools/lsp4ij/client/LanguageClientImpl.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
workspace_configuration
branch
from
e3e296f
to
d1d3b97
Compare
Signed-off-by: azerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support for 'workspace/configuration'