Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent from "implementation class is not specified" with documentMatcher #347

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

angelozerr
Copy link
Contributor

fix: prevent from "implementation class is not specified" with documentMatcher

When documentMatcher is not declared in languageMapping, fileTypeMapping, etc, the following exception is thrown https://github.com/JetBrains/intellij-community/blob/def6433a5dd9f0a984cbc6e2835d27c97f2cb5f0/platform/core-api/src/com/intellij/serviceContainer/LazyExtensionInstance.java#L55

We catch this method, but it is cleaner to avoid calling getInstance if documentMatcher is not declared.

@angelozerr angelozerr added the bug Something isn't working label Jun 12, 2024
@angelozerr angelozerr added this to the 0.0.2 milestone Jun 12, 2024
@angelozerr angelozerr self-assigned this Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 23.63%. Comparing base (0b8414c) to head (ba149d9).

Files Patch % Lines
...sion/FileNamePatternMappingExtensionPointBean.java 0.00% 5 Missing ⚠️
...n/extension/FileTypeMappingExtensionPointBean.java 0.00% 5 Missing ⚠️
...n/extension/LanguageMappingExtensionPointBean.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   23.67%   23.63%   -0.05%     
==========================================
  Files         265      265              
  Lines        9093     9111      +18     
  Branches     1243     1243              
==========================================
  Hits         2153     2153              
- Misses       6535     6553      +18     
  Partials      405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fbricon fbricon merged commit 28ce1d3 into redhat-developer:main Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants