-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odo watch is rebuilding the initial version, ignoring pushed modifications #1429
Comments
@apupier I am not able to reproduce this Test Env : CDK 3.8.0 Test step :
Even i can not reproduce the issue by directly using odo command @apupier can you try it again. i do not think it's a platform specific issue |
I tried again and can still reproduce. |
Thanks for sharing, will take a look |
@amitkrout We have released new version of OpenShift connector to marketplace that uses |
@kadel I am adding some logs info. I don't find any suspious event in the log. Please have look if that helps you Push logs before change -
Push log after change -
|
@kadel AS discussed, first ran
|
I suspect that this is caused because of wrong handling of the backslashes on windows ( This is a line that I think poinst to the problem
From the output I can also see that we are handling ignores wrong way
beggigin of the path is with because of this the ignore is not matched and later the wach is added into the ignored directory
/cc @mik-dass |
@cdrage please test that this was fixed by your watch PR |
@kadel My PR looks to have not fixed it. I'll take this up! |
push works on windows /remove-priority high |
@kadel: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@girishramnani I notice that the issue has been removed from the sprint 164 without being integrated in the following 165 |
Hi @apupier it is our Sprint 165. Ignore is not fixed yet, it won't get into the next release but it should be in one after that (I hope) |
This PR fixes the invalid paths that are being passed into OpenShift due to using `FromSlash` that defaults to whatever backslash / forwardslash the OS uses. This changes it so that `ToSlash` is used for transfering as *all* containers in OpenShift are Linux-based and thus forward-slashes are required. Closes issue redhat-developer#1429
This PR fixes the invalid paths that are being passed into OpenShift due to using `FromSlash` that defaults to whatever backslash / forwardslash the OS uses. This changes it so that `ToSlash` is used for transfering as *all* containers in OpenShift are Linux-based and thus forward-slashes are required. Closes issue #1429
Validated the issue against the standalone odo beta3 release, Win10, Command shell and it works as expected. Steps i followed:
First click without updating the GreetingsServiceImpl.java file Second click after updating the GreetingsServiceImpl.java file (odo watch detects the changes in the shell) Third click after updating the GreetingsServiceImpl.java file (odo watch detects the changes in the shell) |
[kind/bug]
What versions of software are you using?
odo version
:odo v0.0.20 (bd3e74a)
Server: https://172.18.93.45:8443
Kubernetes: v1.11.0+d4cacc0
How did you run odo exactly?
using VS Code OpenShift connector extension.
Actual behavior
to test it, you can create a route (will be proposed when right-click Open In browser in VS Code) it will lead to something like:
click on the firs blue button, the message should contain the modifications of the message that was made in GreetingsServiceImpl
Expected behavior
Any logs, error output, etc?
The text was updated successfully, but these errors were encountered: