Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable substitution does not work in pod-overrides and container-overrides #6764

Open
valaparthvi opened this issue Apr 22, 2023 · 6 comments
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@valaparthvi
Copy link
Contributor

components:
  - container:
      image: quay.io/tkral/devbox-demo-devbox
    attributes:
      pod-overrides:
        spec:
          serviceAccountName: "{{RESOURCE_NAME}}"
variables:
  RESOURCE_NAME: my-go-app
$ odo dev
 /  \__     Developing using the "restapi" Devfile
 \__/  \    Namespace: restapi-mongodb
 /  \__/    odo version: v3.9.0
 \__/

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
Cleaning resources, please wait
 ✗  unable to create or update component: unable to update Deployment restapi-app: Deployment.apps "restapi-app" is invalid: spec.template.spec.serviceAccountName: Invalid value: "{{RESOURCE_NAME}}": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

"{{RESOURCE NAME}}" should be replaced by "my-go-app", instead an error is returned.

This probably needs to be fixed on the devfile/library side.

/kind bug
/area devfile-spec

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Apr 22, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Apr 22, 2023
@valaparthvi valaparthvi self-assigned this Apr 26, 2023
@github-actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 26, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Aug 26, 2023
@rm3l
Copy link
Member

rm3l commented Aug 28, 2023

Still relevant as an issue.

/reopen
/remove-lifecycle rotten
/remove-lifecycle stale

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

@rm3l: Reopened this issue.

In response to this:

Still relevant as an issue.

/reopen
/remove-lifecycle rotten
/remove-lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot reopened this Aug 28, 2023
@openshift-ci openshift-ci bot removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 28, 2023
@rm3l rm3l removed the status in odo Project Aug 28, 2023
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2023
@rm3l
Copy link
Member

rm3l commented Nov 27, 2023

/remove-lifecycle stale
/lifecycle frozen
/remove-status needs-triage

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 27, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: No status
Development

No branches or pull requests

2 participants