This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Fix pr-check build issues when building dashboard #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few issues in building dashboard using native profile - Bower update step requires non-root user; fails silently otherwise. Build now creates a new user and executes the git clone and maven build as them - It seems a higher verison of nodejs is required to build Che; there is some issue in the `gulp build` step that occurs (module not found) when nodejs4 is used. Uses the rh-nodejs8 package instead. Signed-off-by: Angel Misevski
@amisevsk The che server [build 659] failed.If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel. |
ScrewTSW
reviewed
Oct 11, 2018
ScrewTSW
approved these changes
Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a few issues in building dashboard using native profile
gulp buildstep that occurs (module not found) when nodejs4 is used. Uses the rh-nodejs8 package instead.npm install -g gulp boweris no longer necessary.What issues does this PR fix or reference?
#944
How have you tested this PR?
Build succeeds locally executing
docker build ./dockerfiles/pr-check