-
Notifications
You must be signed in to change notification settings - Fork 91
Do not skip acceptance tests if the main Dockerfile is changed. #1168
Do not skip acceptance tests if the main Dockerfile is changed. #1168
Conversation
/hold |
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 33 33
Lines 2839 2839
=======================================
Hits 1649 1649
Misses 1029 1029
Partials 161 161 Continue to review full report at Codecov.
|
/unhold |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
@pmacik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Pavel Macík <[email protected]>
3e497dc
to
527e9ad
Compare
New changes are detected. LGTM label has been removed. |
Rebased to latest |
…at-developer#1168) Signed-off-by: Pavel Macík <[email protected]>
…at-developer#1168) Signed-off-by: Pavel Macík <[email protected]>
…at-developer#1168) Signed-off-by: Pavel Macík <[email protected]>
Signed-off-by: Pavel Macík [email protected]
Changes
Currently the skip detector misses the main
Dockerfile
as in case of #1166. This PR:Dockerfile
.startsWith
method as for directories)The skipping filter for acceptance tests with OpenShift (CI) is covered by openshift/release#29427
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.