Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Change quay.io/redhat-developer/servicebinding-operator:index image to file-based catalog #1179

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jun 24, 2022

Signed-off-by: Pavel Macík [email protected]

Fixes: #1180

Changes

This PR:

  • Changes the index image to be file-based

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik changed the title Change operator index image to file-based ]Change operator index image to file-based Jun 24, 2022
@pmacik pmacik changed the title ]Change operator index image to file-based WIP: Change operator index image to file-based Jun 24, 2022
@pmacik pmacik changed the title WIP: Change operator index image to file-based WIP: Change quay.io/redhat-developer/servicebinding-operator:index image to file-based catalog Jun 24, 2022
@pmacik pmacik force-pushed the file-based-operator-index branch 2 times, most recently from c3bff8f to 32a2d6f Compare June 24, 2022 11:24
@pmacik pmacik force-pushed the file-based-operator-index branch from 32a2d6f to ad6a74b Compare June 24, 2022 11:29
@pmacik pmacik changed the title WIP: Change quay.io/redhat-developer/servicebinding-operator:index image to file-based catalog Change quay.io/redhat-developer/servicebinding-operator:index image to file-based catalog Jun 24, 2022
@pmacik pmacik added kind/bug Something isn't working ci CI related issues labels Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1179 (ad6a74b) into master (7dd72db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files          33       33           
  Lines        2782     2782           
=======================================
  Hits         1633     1633           
  Misses        988      988           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd72db...ad6a74b. Read the comment docs.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 3afddcc into redhat-developer:master Jun 24, 2022
pmacik added a commit that referenced this pull request Jul 27, 2022
@pmacik pmacik deleted the file-based-operator-index branch August 12, 2022 15:02
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved ci CI related issues kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install SBO to OpenShift from quay.io/redhat-developer/servicebinding-operator:index index image
2 participants