Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Add docs to set permissions due to Kubernetes bug #1191

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Add docs to set permissions due to Kubernetes bug #1191

merged 1 commit into from
Aug 8, 2022

Conversation

baijum
Copy link
Member

@baijum baijum commented Jul 29, 2022

Fixes #1157

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #1191 (4a5b970) into master (55f57ea) will not change coverage.
The diff coverage is n/a.

❗ Current head 4a5b970 differs from pull request most recent head f2384fe. Consider uploading reports for the commit f2384fe to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          33       33           
  Lines        2839     2839           
=======================================
  Hits         1649     1649           
  Misses       1029     1029           
  Partials      161      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f57ea...f2384fe. Read the comment docs.

sadlerap
sadlerap reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this fix, lgtm.
Would like a review from @Srivaralakshmi before merging.

docs/userguide/modules/projecting-binding-data/pages/projecting-binding-data.adoc Show resolved Hide resolved
@baijum baijum mentioned this pull request Aug 1, 2022
Closed
4 tasks
sadlerap
sadlerap reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like a review from @Srivaralakshmi as well.

docs/userguide/modules/projecting-binding-data/pages/projecting-binding-data.adoc Outdated Show resolved Hide resolved
@baijum baijum mentioned this pull request Aug 4, 2022
Closed
Srivaralakshmi
Srivaralakshmi suggested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baijum PTAL at the suggested changes. Thanks!

docs/userguide/modules/projecting-binding-data/pages/projecting-binding-data.adoc Outdated Show resolved Hide resolved
@fbm3307
Copy link
Contributor

fbm3307 commented Aug 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 8, 2022
@fbm3307
Copy link
Contributor

fbm3307 commented Aug 8, 2022

/approve

@baijum @sadlerap @Srivaralakshmi
Add docs to set permissions due to Kubernetes bug
f2384fe 
Fixes redhat-developer#1157

Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Andy Sadler <[email protected]>
Co-authored-by: Srivaralakshmi Ramani <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Aug 8, 2022
@baijum
Copy link
Member Author

baijum commented Aug 8, 2022

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

@baijum: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum, fbm3307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2022
@fbm3307
Copy link
Contributor

fbm3307 commented Aug 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit db5b21b into redhat-developer:master Aug 8, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
@baijum @sadlerap
@Srivaralakshmi @pmacik
Add docs to set permissions due to Kubernetes bug (redhat-developer#1191
19aa339 
)

Fixes redhat-developer#1157

Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Andy Sadler <[email protected]>
Co-authored-by: Srivaralakshmi Ramani <[email protected]>

Co-authored-by: Andy Sadler <[email protected]>
Co-authored-by: Srivaralakshmi Ramani <[email protected]>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
@baijum @sadlerap
@Srivaralakshmi @pmacik
Add docs to set permissions due to Kubernetes bug (redhat-developer#1191
a9f011b 
)

Fixes redhat-developer#1157

Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Andy Sadler <[email protected]>
Co-authored-by: Srivaralakshmi Ramani <[email protected]>

Co-authored-by: Andy Sadler <[email protected]>
Co-authored-by: Srivaralakshmi Ramani <[email protected]>
@baijum baijum deleted the permission-docs branch November 11, 2022 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadlerap sadlerap sadlerap left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi requested changes

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

Assignees

@fbm3307 fbm3307

Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service-binding-operator - crunchyDB operator populating tls.key with wrong permissions
5 participants
@baijum @fbm3307 @sadlerap @Srivaralakshmi @openshift-merge-robot