Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Correct asciidoc syntax for link #1196

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

baijum
Copy link
Member

@baijum baijum commented Aug 8, 2022

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Baiju Muthukadan <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from baijum by writing /assign @baijum in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1196 (b31e42e) into master (db5b21b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          33       33           
  Lines        2839     2839           
=======================================
  Hits         1649     1649           
  Misses       1029     1029           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5b21b...b31e42e. Read the comment docs.

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baijum Approved!

@baijum baijum merged commit 715859c into redhat-developer:master Aug 9, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
@baijum baijum deleted the asciidoc branch November 11, 2022 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants