Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Update DCO to align with redhat-developer organization guidelines. #1200

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Aug 11, 2022

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1200 (59adf01) into master (c233e02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files          33       33           
  Lines        2838     2838           
=======================================
  Hits         1645     1645           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c233e02...59adf01. Read the comment docs.

@baijum
Copy link
Member

baijum commented Aug 11, 2022

@pmacik Can you point me where these guidelines are written?

@pmacik
Copy link
Contributor Author

pmacik commented Aug 11, 2022

@pmacik Can you point me where these guidelines are written?

@baijum the guidelines were written in a Red Hat internal email.

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@baijum
Copy link
Member

baijum commented Aug 16, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dbfbf65 into redhat-developer:master Aug 16, 2022
@pmacik pmacik deleted the dco branch August 18, 2022 12:09
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants