Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Upgrade Go to 1.17 and Operator SDK to 1.17.0 #1205

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

baijum
Copy link
Member

@baijum baijum commented Aug 22, 2022

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Dockerfile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1205 (acd56b6) into master (ea3ceb9) will not change coverage.
The diff coverage is n/a.

❗ Current head acd56b6 differs from pull request most recent head 2527d55. Consider uploading reports for the commit 2527d55 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1205   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files          33       33           
  Lines        2838     2838           
=======================================
  Hits         1645     1645           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3ceb9...2527d55. Read the comment docs.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Apart from changing the image, looks good to me.

Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Pavel Macík <[email protected]>
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We're also going to have to update midstream to use go 1.17, right?

@openshift-ci openshift-ci bot added the lgtm label Aug 25, 2022
@baijum
Copy link
Member Author

baijum commented Aug 25, 2022

We're also going to have to update midstream to use go 1.17, right?

Yes, we can do the same for downstream.

@pmacik
Copy link
Contributor

pmacik commented Aug 25, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 712545e into redhat-developer:master Aug 25, 2022
@baijum baijum deleted the go-version branch November 11, 2022 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants