-
Notifications
You must be signed in to change notification settings - Fork 91
Upgrade Go to 1.17 and Operator SDK to 1.17.0 #1205
Upgrade Go to 1.17 and Operator SDK to 1.17.0 #1205
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 57.96% 57.96%
=======================================
Files 33 33
Lines 2838 2838
=======================================
Hits 1645 1645
Misses 1032 1032
Partials 161 161 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Apart from changing the image, looks good to me.
@baijum the unit test helpers should also be updated for Go 1.17: |
Done. |
Signed-off-by: Baiju Muthukadan <[email protected]> Co-authored-by: Pavel Macík <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We're also going to have to update midstream to use go 1.17, right?
Yes, we can do the same for downstream. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Baiju Muthukadan [email protected]
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.