Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Bump Version 1.2.0 #1212

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Bump Version 1.2.0 #1212

merged 1 commit into from
Sep 2, 2022

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Sep 2, 2022

In preparation for release of SB 1.2.0

Signed-off-by: Feny Mehta [email protected]

@fbm3307
Bump Version 1.2.0
78d1af2 
Signed-off-by: Feny Mehta <[email protected]>
@fbm3307 fbm3307 added the release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch label Sep 2, 2022
@fbm3307
Copy link
Contributor Author

fbm3307 commented Sep 2, 2022

/hold

@fbm3307
Copy link
Contributor Author

fbm3307 commented Sep 2, 2022

/unhold

@codecov
Copy link

codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Merging #1212 (78d1af2) into master (de41ea1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          33       33           
  Lines        2844     2844           
=======================================
  Hits         1651     1651           
  Misses       1032     1032           
  Partials      161      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de41ea1...78d1af2. Read the comment docs.

sadlerap
sadlerap approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 2, 2022
@sadlerap
Copy link
Contributor

sadlerap commented Sep 2, 2022

Q: does #1211 need to land first?

@shruthihub
Copy link
Contributor

/lgtm

@pmacik
Copy link
Contributor

pmacik commented Sep 2, 2022

Q: does #1211 need to land first?

Nope that is independent

@pmacik
Copy link
Contributor

pmacik commented Sep 2, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit c13bba5 into redhat-developer:master Sep 2, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Sep 2, 2022
@fbm3307 @pmacik
Bump Version 1.2.0 (redhat-developer#1212)
13c056c 
Signed-off-by: Feny Mehta <[email protected]>

Signed-off-by: Feny Mehta <[email protected]>
fbm3307 added a commit to fbm3307/service-binding-operator that referenced this pull request Sep 5, 2022
@fbm3307
Bump Version 1.2.0 (redhat-developer#1212)
d5ef2a7 
Signed-off-by: Feny Mehta <[email protected]>

Signed-off-by: Feny Mehta <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Sep 5, 2022
@fbm3307
Bump Version 1.2.0 (#1212) (#1214)
662f5f2 
Signed-off-by: Feny Mehta <[email protected]>

Signed-off-by: Feny Mehta <[email protected]>

Signed-off-by: Feny Mehta <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadlerap sadlerap sadlerap approved these changes

@baijum baijum Awaiting requested review from baijum

Assignees

@pmacik pmacik

@sadlerap sadlerap

@shruthihub shruthihub

Labels
approved lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fbm3307 @sadlerap @shruthihub @pmacik @openshift-merge-robot