This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Remove duplicate scenario #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pavel Macík <[email protected]>
pmacik
added
release/v1.2.x
pmacik
force-pushed
the
remove-duplicate-scenario
branch
from
d247414
to
48dec3b
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 33 33
Lines 2797 2797
=======================================
Hits 1624 1624
Misses 1018 1018
Partials 155 155 Continue to review full report at Codecov.
|
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Oct 11, 2022
Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]>
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Oct 11, 2022
Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Macík [email protected]
Project a v1beta1 service binding using a v1beta1 workload mappingscenario is present twice in exact copies.Changes
This PR removes the duplicate scenario.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.