-
Notifications
You must be signed in to change notification settings - Fork 91
Rebind workloads when their mappings change #1296
Rebind workloads when their mappings change #1296
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 58.06% 58.23% +0.17%
==========================================
Files 33 35 +2
Lines 2797 2988 +191
==========================================
+ Hits 1624 1740 +116
- Misses 1018 1082 +64
- Partials 155 166 +11
Continue to review full report at Codecov.
|
0574dda
to
42ce7b2
Compare
/retest |
2 similar comments
/retest |
/retest |
42ce7b2
to
b370078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small comment about logging
5288dcb
to
5bb6729
Compare
/lgtm |
/retest |
5bb6729
to
67fd0e4
Compare
/retest |
1 similar comment
/retest |
Signed-off-by: Andy Sadler <[email protected]>
67fd0e4
to
9096e4f
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andy Sadler [email protected]
Changes
This works in three stages:
servicebinding.io/mapping
annotation on all relevant service bindings./kind enhancement
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.