Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Update Crunchy Postgres Operator to v5.3.0 in acceptance tests #1328

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Update Crunchy Postgres Operator to v5.3.0 in acceptance tests #1328

merged 1 commit into from
Dec 21, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Dec 21, 2022

Signed-off-by: Pavel Macík [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Dec 21, 2022
@pmacik pmacik force-pushed the fix/crunchy-operator branch 2 times, most recently from 912be3c to eb97cbf Compare December 21, 2022 10:36
@sadlerap
Copy link
Contributor

Looks like it's timing out on CSV installation approval: https://github.com/redhat-developer/service-binding-operator/actions/runs/3748527285/jobs/6365966647#step:9:6403

sadlerap
sadlerap approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Dec 21, 2022 •
edited
Loading

Codecov Report

Merging #1328 (10f1f4e) into master (c3d079d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d079d...10f1f4e. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit cc38518 into redhat-developer:master Dec 21, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Dec 21, 2022
@pmacik @web-flow
Update Crunchy Postgres Operator to v5.3.0 in acceptance tests (redha…
622808c 
…t-developer#1328)

Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Dec 22, 2022
@service-binding-operator-bot @pmacik
Update Crunchy Postgres Operator to v5.3.0 in acceptance tests (#1328) (
c257bed 
#1333)

Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
Co-authored-by: Pavel Macík <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadlerap sadlerap sadlerap approved these changes

@baijum baijum Awaiting requested review from baijum

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

Assignees

@sadlerap sadlerap

Labels
approved lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmacik @sadlerap @openshift-merge-robot