Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Fixed the environment issue in CI #1335

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

tisutisu
Copy link
Contributor

@tisutisu tisutisu commented Jan 3, 2023

Signed-off-by: Sushanta Das [email protected]

Changes

This PR will fix the environment issue observed while uploading performance kpi data during periodic CI job here https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/34971/rehearse-34971-periodic-ci-redhat-developer-service-binding-operator-master-4.11-performance-latest-openshift/1606303067391660032

Since the upload_data.py script is running in virtual environment, the env variables from the make file needs to be passed explicitly.

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jan 3, 2023
@openshift-ci openshift-ci bot requested review from baijum and sadlerap January 3, 2023 06:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

Hi @tisutisu. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1335 (d25ac1e) into master (9f7f791) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1335   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7f791...d25ac1e. Read the comment docs.

@baijum
Copy link
Member

baijum commented Jan 4, 2023

/lgtm

@pmacik
Copy link
Contributor

pmacik commented Jan 9, 2023

/test performance

Copy link
Contributor

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2023
@pmacik pmacik merged commit b578dcd into redhat-developer:master Jan 9, 2023
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Jan 19, 2023
…eveloper#1363

* Adding support to upload performance kpi data to opensearch (redhat-developer#1331)
* Fixed the environment issue in CI (redhat-developer#1335)
* Added metadata with performance kpi data upload (redhat-developer#1363)

Signed-off-by: Pavel Macík <[email protected]>
@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Jan 19, 2023
openshift-merge-robot pushed a commit that referenced this pull request Jan 19, 2023
* Adding support to upload performance kpi data to opensearch (#1331)
* Fixed the environment issue in CI (#1335)
* Added metadata with performance kpi data upload (#1363)

Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
Co-authored-by: Sushanta Das <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved kind/enhancement New feature or request lgtm needs-ok-to-test release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants