-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
Signed-off-by: Sushanta Das <[email protected]>
Hi @tisutisu. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
=======================================
Coverage 58.16% 58.16%
=======================================
Files 35 35
Lines 3007 3007
=======================================
Hits 1749 1749
Misses 1090 1090
Partials 168 168 Continue to review full report at Codecov.
|
/lgtm |
/test performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…eveloper#1363 * Adding support to upload performance kpi data to opensearch (redhat-developer#1331) * Fixed the environment issue in CI (redhat-developer#1335) * Added metadata with performance kpi data upload (redhat-developer#1363) Signed-off-by: Pavel Macík <[email protected]>
* Adding support to upload performance kpi data to opensearch (#1331) * Fixed the environment issue in CI (#1335) * Added metadata with performance kpi data upload (#1363) Signed-off-by: Pavel Macík <[email protected]> Signed-off-by: Pavel Macík <[email protected]> Co-authored-by: Sushanta Das <[email protected]>
Signed-off-by: Sushanta Das [email protected]
Changes
This PR will fix the environment issue observed while uploading performance kpi data during periodic CI job here https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/34971/rehearse-34971-periodic-ci-redhat-developer-service-binding-operator-master-4.11-performance-latest-openshift/1606303067391660032
Since the upload_data.py script is running in virtual environment, the env variables from the make file needs to be passed explicitly.
/kind enhancement
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.