Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jan 19, 2023

Signed-off-by: Pavel Macík [email protected]

Currently, the performance as part of simulated users actions it applies YAML files with resources. Those resources contain also the cluster-wide resources such as ClusterRole or ClusterWorkloadResourceMapping.

Since that YAML is applied by each of the simulated users those cluster-wide resources are constantly being "updated" by which sometimes causes the "the object has been modified; please apply your changes to the latest version and try again" error that fails the test.

That causes the performance testing jobs to be flaky.

Changes

This PR fixes the situation by applying the cluster-wide resources only once instead of for each for each iteration.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added approved lgtm cherry-pick release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Jan 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jan 19, 2023
@pmacik pmacik changed the title Create cluster-wide resources only once in performance test (#1308) cherry-pick(release-v1.3.x): Create cluster-wide resources only once in performance test (#1308) Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1373 (076038f) into release-v1.3.x (e23698a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.3.x    #1373   +/-   ##
===============================================
  Coverage           57.99%   57.99%           
===============================================
  Files                  33       33           
  Lines                2816     2816           
===============================================
  Hits                 1633     1633           
  Misses               1026     1026           
  Partials              157      157           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23698a...076038f. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 4bcbd99 into redhat-developer:release-v1.3.x Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants