Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default shell #397

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Use default shell #397

merged 2 commits into from
Sep 14, 2020

Conversation

evidolob
Copy link
Collaborator

This PR remove hardcoded /bin/bash shell for any tkn commands, this force to use default system shell.
Fix: #363

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Sep 14, 2020
Signed-off-by: Yevhen Vydolob <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #397 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   72.57%   72.56%   -0.01%     
==========================================
  Files          54       54              
  Lines        3664     3663       -1     
  Branches      660      659       -1     
==========================================
- Hits         2659     2658       -1     
  Misses       1005     1005              
Impacted Files Coverage Δ
src/util/windowUtils.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e0637...9c9faff. Read the comment docs.

@evidolob evidolob merged commit 5213ea6 into master Sep 14, 2020
@evidolob evidolob deleted the fix-363 branch September 14, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show logs changes shell
3 participants