Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'when' to diagram #431

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add 'when' to diagram #431

merged 1 commit into from
Oct 22, 2020

Conversation

evidolob
Copy link
Collaborator

Fix: #416

Demo:
Screenshot 2020-10-20 at 17 17 38

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Oct 20, 2020
@evidolob
Copy link
Collaborator Author

@siamaksade Can you look on screen?

@codecov-io
Copy link

Codecov Report

Merging #431 into master will increase coverage by 0.19%.
The diff coverage is 83.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   74.42%   74.62%   +0.19%     
==========================================
  Files          61       61              
  Lines        3922     4008      +86     
  Branches      714      734      +20     
==========================================
+ Hits         2919     2991      +72     
- Misses       1003     1017      +14     
Impacted Files Coverage Δ
src/model/pipeline/pipeline-model.ts 77.66% <50.00%> (-3.00%) ⬇️
src/pipeline/pipeline-graph.ts 75.65% <80.00%> (-0.46%) ⬇️
src/yaml-support/tkn-yaml.ts 90.55% <97.18%> (+1.01%) ⬆️
src/model/common.ts 93.00% <100.00%> (+0.09%) ⬆️
src/tekton/addtrigger.ts 82.67% <0.00%> (+2.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a607c6...a42acc5. Read the comment docs.

@evidolob evidolob merged commit dc586c1 into master Oct 22, 2020
@evidolob evidolob deleted the add-when branch October 22, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display when expressions in diagram
3 participants