Add debug support taskrun #627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 67.62% 68.29% +0.66%
==========================================
Files 103 111 +8
Lines 6333 6592 +259
Branches 1154 1185 +31
==========================================
+ Hits 4283 4502 +219
- Misses 2050 2090 +40
Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -987,4 +1046,4 @@ | |||
| "validator": "^11.0.0", | |||
| "vscode-kubernetes-tools-api": "1.3.0" | |||
| } | |||
| } | |||
| } | |||
|
@sudhirverma I got this error: And other suggestion, I think it would be better to swap tektonhub and debug view, to keep tektonhub last. |
sudhirverma
force-pushed
the
623
branch
2 times, most recently
from
b7ae083
to
2da6c77
Compare
src/debugger/debug-tree-view.ts
Outdated
| export async function debugTreeView(): Promise<TektonNode[]> { | ||
| if (sessions && sessions.size !== 0) { | ||
| const children = []; | ||
| for (const [key, value] of sessions) { |
There was a problem hiding this comment.
Please fix 'value' is assigned a value but never used
test/debugger/debugExplorer.test.ts
Outdated
| import * as sinonChai from 'sinon-chai'; | ||
| import sinon = require('sinon'); | ||
| import { DebugExplorer } from '../../src/debugger/debugExplorer'; | ||
| import { TestItem } from '../tekton/testTektonitem'; |
There was a problem hiding this comment.
Please fix 'TestItem' is defined but never used
test/debugger/debugExplorer.test.ts
Outdated
| import sinon = require('sinon'); | ||
| import { DebugExplorer } from '../../src/debugger/debugExplorer'; | ||
| import { TestItem } from '../tekton/testTektonitem'; | ||
| import { TknImpl } from '../../src/tkn'; |
There was a problem hiding this comment.
And this 'TknImpl' is defined but never used
src/cli-command.ts
Outdated
| @@ -408,6 +416,42 @@ export class Command { | |||
| } | |||
| } | |||
|
|
|||
| static loginToContainer(container: string, podName: string, namespace: string): CliCommand { | |||
| if (ocFallBack.get('ocFallBack')) { | |||
| return newOcCommand('exec', '-it', '-n', namespace, '-c', container, podName, 'bash'); | |||
There was a problem hiding this comment.
I receive message
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
Could you verify that, and use new type of the command
There was a problem hiding this comment.
okay I will use kubectl exec mypod -i -t -- bash
Fix: #623