Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent by 4 instead of 2 spaces #902

Closed
vorburger opened this issue May 14, 2023 · 4 comments · Fixed by #903
Closed

Indent by 4 instead of 2 spaces #902

vorburger opened this issue May 14, 2023 · 4 comments · Fixed by #903
Milestone

Comments

@vorburger
Copy link
Contributor

vorburger commented May 14, 2023

Is 4 space indention currently hard-coded?

I (now) prefer 2 instead of 4 space indendation in XML files.

It's also recommended e.g. on https://maven.apache.org/guides/development/guide-documentation-style.html for pom.xml.

I tried to look for a configuration to change this on https://github.com/redhat-developer/vscode-xml/blob/main/docs/Formatting.md, but couldn't find any....

vorburger added a commit to vorburger/ch.vorburger.exec that referenced this issue May 14, 2023
See redhat-developer/vscode-xml#902
why this now uses 4 instead of 2 space indendation.
vorburger added a commit to vorburger/vorburger-dotfiles-bin-etc that referenced this issue May 14, 2023
Used e.g. for vorburger/ch.vorburger.exec#120.

Unfortunately uses 4 instead of 2 spaces; see
redhat-developer/vscode-xml#902.
@vorburger
Copy link
Contributor Author

What's funny is that even (some of, it's inconsistent) the examples on https://github.com/redhat-developer/vscode-xml/blob/main/docs/Formatting.md are intended with 2 instead of 4 spaces...

Maybe I'm missing something - if so, it's probably worth to clarifty better in docs?

vorburger added a commit to vorburger/ch.vorburger.exec that referenced this issue May 14, 2023
See redhat-developer/vscode-xml#902
why this now uses 4 instead of 2 space indendation.
@angelozerr
Copy link
Contributor

angelozerr commented May 14, 2023

Nothing are hard coded. We use standard format settings from vscode, I mean editor.insertSpaces and editor.tabSize

@vorburger
Copy link
Contributor Author

@angelozerr duh! I see. Sorry, I'm dumb - that wasn't clear to me. I'll propose a small PR to add a line to the doc.

vorburger added a commit to vorburger/vorburger-dotfiles-bin-etc that referenced this issue May 14, 2023
@angelozerr
Copy link
Contributor

I'll propose a small PR to add a line to the doc.

Any contribution are welcome!

vorburger added a commit to vorburger/ch.vorburger.exec that referenced this issue May 14, 2023
vorburger added a commit to vorburger/vscode-xml that referenced this issue May 14, 2023
rgrunber pushed a commit to vorburger/vscode-xml that referenced this issue Nov 14, 2023
- Fixes redhat-developer#902

Signed-off-by: Michael Vorburger ⛑️ <[email protected]>
rgrunber pushed a commit that referenced this issue Nov 14, 2023
- Fixes #902

Signed-off-by: Michael Vorburger ⛑️ <[email protected]>
@rgrunber rgrunber added this to the 0.27.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants