Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XSL support #56

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Add XSL support #56

merged 1 commit into from
Oct 5, 2018

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Oct 4, 2018

(Partially?) fixes #55

For some reason there's no autocompletion support in the xsl. @angelozerr do we need to modify the server as well?

Signed-off-by: Fred Bricon <[email protected]>
@angelozerr
Copy link
Contributor

The use of https://www.w3.org/1999/XSL/Transform don't give you the XML Schema, you have 3 XML Schema version for XSL. If you wish to support validation and completion for xsl, you need the my POC about XSL extension https://github.com/angelozerr/lsp4xml/tree/master/extensions/org.eclipse.lsp4xml.xsl but this https://github.com/angelozerr/lsp4xml/blob/master/extensions/org.eclipse.lsp4xml.xsl/src/main/java/org/eclipse/lsp4xml/xsl/XSLURIResolverExtension.java#L34 should be fixed (I think core should provide a folder where we can deploy some files of lsp4xml).

Today the extesnion doesn't use the version declared in the XML to choose the well XML Schema, I must do it.

@fbricon
Copy link
Collaborator Author

fbricon commented Oct 4, 2018

@angelozerr I think xsl support should probably be a core feature as well

@fbricon
Copy link
Collaborator Author

fbricon commented Oct 4, 2018

Regardless, I believe this PR is valuable on its own, even without the server components. @NikolasKomonen feel free to give it a try

@angelozerr
Copy link
Contributor

@angelozerr I think xsl support should probably be a core feature as well

Ok, I will dot it. Please note it exists an issur for XSL at eclipse/lemminx#91

Copy link
Contributor

@NikolasKomonen NikolasKomonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@NikolasKomonen NikolasKomonen merged commit 0004f19 into redhat-developer:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add XSL support
3 participants