Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version breaks auto-save formatting #366

Closed
ekristen opened this issue Sep 23, 2020 · 2 comments · Fixed by #368
Closed

Latest version breaks auto-save formatting #366

ekristen opened this issue Sep 23, 2020 · 2 comments · Fixed by #368
Assignees

Comments

@ekristen
Copy link

Not sure what happened but with the latest version it stopped honoring the workspace vscode settings.

I have a .vscode/settings.json

{
  "[yaml]": {
    "editor.tabSize": 4,
    "editor.insertSpaces": true
  }
}

All files opened are showing 2 spaces instead of 4, when saving it's auto-formats back to 2.

If I manually change the file back to 4 and save, it does not format back to 4 it stays at 2.

Downgrading to 0.10.1 brings back the expected behavior.

@JPinkney
Copy link
Contributor

Can confirm the issue. I think this: https://github.com/redhat-developer/yaml-language-server/pull/305/files PR introduced the formatting issue

@stefanbuck
Copy link

I'm using the following .editorconfig file and saving a file auto-formats the file to 4 spaces.

[*.{yml,json}]
indent_size = 2

bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
update readme with example of an array of glob patterns for schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants